-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Firfox profiles #73
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for your contribution.
A few points:
-
Please add the extra dependency to the setup file so it would include the dll file:
https://github.com/zumoshi/BrowserSelect/blob/master/BrowserSelect/installer.nsi#L40 -
As I mentioned in the comment, you need to also commit the csproj file
-
I get 2 firefoxes on a default installation before creating any profiles
Perhaps you have to remove one like I did for chrome? -
I'm not very familiar with how firefox profiles work so I may be doing something wrong but the app seems to lag behind one profile? (as in I create the profile, browserselect won't pick it up, I create another profile, it picks up the previous one)
I did run firefox with the new profile before clicking on refresh browsers from settings.
There are also some unlabeled firefox icons (without any profile name)
- If there are two firefox instances (of different profiles) open, trying to open a link in one of them just opens a new firefox window with no link
This feature was brought up in #14 but I didn't find any way to communicate with open instances to open a new tab in a specific profile which is why this wasn't implemented.
Which command-line flags are you using to open the link in a new tab of a running instance of a certain profile in firefox?
@@ -1,5 +1,6 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<packages> | |||
<package id="ini-parser" version="2.5.2" targetFramework="net40" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also include changes to the .csproj
file, specifically this addition:
<Reference Include="INIFileParser, Version=2.5.2.0, Culture=neutral, PublicKeyToken=79af7b307b65cf3c, processorArchitecture=MSIL">
<HintPath>..\packages\ini-parser.2.5.2\lib\net20\INIFileParser.dll</HintPath>
</Reference>
I'll try resolving these issue later. It seems that there are some problems on Firefox handling link in specified profile. |
This seems to work consistently for me: This option seems to have been around for a while now (seems to have worked back in Jan 2020) for this user; Adding the new-tab parameter may ensure better (backward) support?? |
See here for official documentation on Firefox profiles management.