Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin dir name clarification #3646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndrewDDavis
Copy link

Micro rejects the plugin if the dir-name does not match the regex ^[_A-Za-z0-9]+$.

@usfbih8u
Copy link
Contributor

That is not true. All my plugin directories use -.

Micro requires the name in the repo.json file to comply with ^[_A-Za-z0-9]+$.

Try it, and it should work for you.

@niten94
Copy link
Contributor

niten94 commented Feb 1, 2025

That is not true. All my plugin directories use -.

Micro requires the name in the repo.json file to comply with ^[_A-Za-z0-9]+$.

That's right, but the directory name has to match the pattern only when the plugin does not contain repo.json. I think the explanation could be changed to state which name is checked, and the file not being practically required if the plugin isn't published.

I think this issue could be addressed and closed with this pull request too: #3553

@usfbih8u
Copy link
Contributor

usfbih8u commented Feb 1, 2025

You are right. I spoke from memory; I should have checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants