Skip to content

Merge @mikecunha's additions#16

Open
KOLANICH wants to merge 11 commits intozygmuntz:masterfrom
mikecunha:master
Open

Merge @mikecunha's additions#16
KOLANICH wants to merge 11 commits intozygmuntz:masterfrom
mikecunha:master

Conversation

@KOLANICH
Copy link
Copy Markdown

No description provided.

michael.cunha added 11 commits February 20, 2018 19:57
Using 2to3.
Using 2to3. Also cleaned up white space formatting.
Using 2to3.
Using 2to3.
Using 2to3.
Base functionality works after a python setup.py install now. However,
none of the defs that attempt to import csv files from the data
directory work with this commit. It will need a MANIFEST.in and/or
package_data and some work with relative paths.
@KOLANICH KOLANICH changed the title Merge mikecunhas' additions Merge @mikecunha's additions Aug 15, 2018
@shlicshlac
Copy link
Copy Markdown

Why did you propose typecasting dict.items() calls to lists everywhere?

@KOLANICH
Copy link
Copy Markdown
Author

  1. I am not the original author of the code
  2. It is a modification 2to3 does. The automatic way to port python 2 code to python 3 is to run 2to3. It is not very intelligent, so it wraps the funcs returning iterators in python 3 that have been returning lists in python 2 into lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants