Skip to content

Conversation

@SantiagoPittella
Copy link
Collaborator

Warning

This PR aims to main.

This PR adds note transport layer support for the network monitor. It works by using the health check endpoint of the given service (https://github.com/0xMiden/miden-note-transport/blob/main/crates/node/src/node/grpc/mod.rs#L87)

Also, add a copy button for the URLs of the services to be easily accesible and re-arranges the order of the cards.

Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there value in actually exercising the transport layer instead of relying on its self-reporting?

(for example, our own "health" report in the node might just always return Ok(200) 😬)

@SantiagoPittella
Copy link
Collaborator Author

Current view of the monitor:

Screenshot 2026-02-10 at 12 03 11

@SantiagoPittella
Copy link
Collaborator Author

Is there value in actually exercising the transport layer instead of relying on its self-reporting?

Yes, there's value in that. I mostly wanted to have a first version introducing the transport layer, at least with an idea if the service is accessible.

@SantiagoPittella
Copy link
Collaborator Author

@Mirko-von-Leipzig is there a chance for the branch protection rules to have a typo? and be requiring "tests" instead of "test"?

@Mirko-von-Leipzig
Copy link
Collaborator

@Mirko-von-Leipzig is there a chance for the branch protection rules to have a typo? and be requiring "tests" instead of "test"?

The issue is that I refactored tests workflow into ci/tests job and the branch protection rules for main still reference tests. This was fixed for next but has not yet been done for main cc @bobbinth

@bobbinth
Copy link
Contributor

The issue is that I refactored tests workflow into ci/tests job and the branch protection rules for main still reference tests. This was fixed for next but has not yet been done for main cc @bobbinth

Should be all good now.

@Mirko-von-Leipzig Mirko-von-Leipzig merged commit cfbf485 into main Feb 12, 2026
19 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the santiagopittella-network-monitor-transport-layer-integration branch February 12, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants