[1/x] Load LinkLibrary from package; Move Package to miden-package crate in the VM repo
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
force-pushed
the
greenhat/i346-link-lib-package
branch
2 times, most recently
from
4e03159 to
6cd29e1
Compare
Base automatically changed from
greenhat/i314-note-script-compilation
to
next
October 30, 2024 09:16
greenhat
changed the title
Package to miden-package crate in the VM repoPackage to miden-package crate in the VM repo
greenhat
force-pushed
the
greenhat/i346-link-lib-package
branch
from
6cd29e1 to
e60feb6
Compare
greenhat
changed the title
Package to miden-package crate in the VM repoLinkLibrary Miden package support; Move Package to miden-package crate in the VM repo
greenhat
referenced
this pull request
Nov 6, 2024
Load `LinkLibrary` from a Miden package. Remove `MastArtifact` and use `miden_package::MastArtifact`.
greenhat
force-pushed
the
greenhat/i346-link-lib-package
branch
from
e628a40 to
01e78e5
Compare
greenhat
changed the title
LinkLibrary Miden package support; Move Package to miden-package crate in the VM repoLinkLibrary from package; Move Package to miden-package crate in the VM repo
greenhat
changed the title
LinkLibrary from package; Move Package to miden-package crate in the VM repoLinkLibrary from package; Move Package to miden-package crate in the VM repo
which is now stored as `MastForest::advice_map`
greenhat
force-pushed
the
greenhat/i346-link-lib-package
branch
from
c0e9550 to
9c4c9b3
Compare
greenhat
changed the title
LinkLibrary from package; Move Package to miden-package crate in the VM repoLinkLibrary from package; Move Package to miden-package crate in the VM repo
bitwalker
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
LGTM. I'm going to merge this, once the miden-package PR is merged and published, we can switch back to crates.io dependencies. This will prevent compiler releases until we switch back, but that's fine since we anticipate doing a release only after those crates are published anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #346
This PR moves
Packageto a newmiden-packagecrate in the VM repo and implements loadingLinkLibraryfrom the Miden package (MASP) file.The linking is handled in the subsequent #353
TODO:
Packageinto newmiden-packagecrate in the VM repo;MastArtifacttomiden-package;PackageasLinkLibrary::Masp;miden-packagecrate withPackagetype to represent a compiled Miden program/library. miden-vm#1544 first;