Add miden-package crate with Package type to represent a compiled Miden program/library.
#1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
changed the title
miden-package crate with Package type to represent a compiled Miden program/library.miden-package crate with Package type to represent a compiled Miden program/library.
greenhat
force-pushed
the
greenhat/miden-package
branch
4 times, most recently
from
76a4b7e to
9ff342e
Compare
greenhat
force-pushed
the
greenhat/miden-package
branch
from
9ff342e to
7c9b95b
Compare
greenhat
changed the base branch from
next
to
greenhat/library-deser-uncheck-exports
greenhat
force-pushed
the
greenhat/library-deser-uncheck-exports
branch
from
1ca8581 to
3581727
Compare
Base automatically changed from
greenhat/library-deser-uncheck-exports
to
next
November 4, 2024 21:37
greenhat
force-pushed
the
greenhat/miden-package
branch
7 times, most recently
from
41b5f5d to
c5ff6f0
Compare
greenhat
force-pushed
the
greenhat/miden-package
branch
6 times, most recently
from
211f34c to
84ea102
Compare
greenhat
changed the base branch from
next
to
greenhat/i1547-mastforest-add-advicemap
greenhat
changed the title
miden-package crate with Package type to represent a compiled Miden program/library.miden-package crate with Package type to represent a compiled Miden program/library.
greenhat
force-pushed
the
greenhat/i1547-mastforest-add-advicemap
branch
from
eda4a01 to
006e03a
Compare
greenhat
force-pushed
the
greenhat/miden-package
branch
2 times, most recently
from
5ec902e to
d6419ca
Compare
greenhat
force-pushed
the
greenhat/i1547-mastforest-add-advicemap
branch
from
006e03a to
92f3309
Compare
greenhat
force-pushed
the
greenhat/i1547-mastforest-add-advicemap
branch
3 times, most recently
from
2f8f3fe to
93869ef
Compare
greenhat
force-pushed
the
greenhat/miden-package
branch
from
d6419ca to
fe4afa2
Compare
Base automatically changed from
greenhat/i1547-mastforest-add-advicemap
to
next
November 21, 2024 12:01
greenhat
changed the title
miden-package crate with Package type to represent a compiled Miden program/library.miden-package crate with Package type to represent a compiled Miden program/library.
greenhat
force-pushed
the
greenhat/miden-package
branch
from
75bd636 to
3b9b31d
Compare
greenhat
force-pushed
the
greenhat/miden-package
branch
from
3b9b31d to
280d338
Compare
compiled Miden program/library.
`AdviceMap` from iterator constructor.
greenhat
force-pushed
the
greenhat/miden-package
branch
from
1ce2c26 to
9886dc6
Compare
add test for deserializing rustc mangled symbols.
…compiler Reasons: - The `Package` serialization proptests and testing `LibraryPath`, `ProcedureName` with example names produced by the compiler are enough; - The test is fragile and brakes on any change to `Package` underlying types serialization. Updating the `masp` file is non-trivial;
greenhat
force-pushed
the
greenhat/miden-package
branch
from
9886dc6 to
b1354c1
Compare
greenhat
force-pushed
the
greenhat/miden-package
branch
from
514b7fc to
ebc8311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
miden-packagecrate withPackagetype ported from the compiler's ad-hoc implementation to represent a compiled Miden program/library. Besides this, the deserialization of theLibraryPathwas switched to use the unchecked constructors to accommodate the Wasm Component Model names for modules.Please consider reviewing this PR commit-by-commit. I crafted the commits to be focused on a single change and show the evolution of the implementation.
The reasons for the new crate are explained in 0xPolygonMiden/compiler#346
The compiler's PR that uses
miden-packagefrom this PR is 0xPolygonMiden/compiler#349