Fix Linux AppImage startup on AMD systems - #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux AppImages currently bundle
libdrm_amdgpufrom the build environment. On current Arch/Mesa AMD systems, Qt can load that copy before the host-matched library and abort during GLX probing withCould not initialize GLXeven though the host's GLX renderer is healthy.This change makes the generated and tracked AppRun launchers detect AMD DRM devices and preload
/usr/lib/libdrm_amdgpu.so.1when it is available. Non-AMD systems and systems without that host library keep the existing launch path unchanged. The environment-variable overrides exist only to make the launcher behavior testable without writing fake devices under/sys.Verification
python3 -m unittest src.Tools.tests.test_linux_appimage_launcherfailed because the launcher leftLD_PRELOAD=existing.sopython3 -m unittest src.Tools.tests.test_linux_appimage_launcher src.Tools.tests.test_release_workflowpassed all 6 testsf99d33a8, Linux7.2.2-arch1-1-mbp133, Mesa26.2.2, and Radeon Pro 460:VibeCAD 26.3.1RC6window/usr/lib/libdrm_amdgpu.so.1.134.0and Mesa'slibGLX_mesa.so, with the Radeon render node openNo UI layout or visual styling changes are included, so before/after images do not apply.
Compatibility
LD_PRELOADentries are preserved after the host AMD library.