Skip to content

Fix Linux AppImage startup on AMD systems #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
10-X-eng merged 1 commit into from
Sep 4, 2026
Merged

Fix Linux AppImage startup on AMD systems #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions package/rattler-build/linux/AppDir/AppRun
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,21 @@ export FONTCONFIG_PATH=/etc/fonts
# Fix: Use X to run on Wayland
export QT_QPA_PLATFORM=xcb

# The AppImage bundles libdrm_amdgpu from its build environment. On current
# Arch/Mesa systems that copy can make Qt's GLX probe see no framebuffer
# configurations. Preload the host-matched library when AMD hardware is
# present; the loader then reuses it instead of the bundled copy.
drm_root=${VIBECAD_DRM_ROOT:-/sys/class/drm}
libdrm_amdgpu=${VIBECAD_LIBDRM_AMDGPU:-/usr/lib/libdrm_amdgpu.so.1}
for vendor_path in "$drm_root"/card*/device/vendor; do
[ -r "$vendor_path" ] || continue
if [ "$(cat "$vendor_path")" = "0x1002" ] && [ -r "$libdrm_amdgpu" ]; then
LD_PRELOAD="$libdrm_amdgpu${LD_PRELOAD:+:$LD_PRELOAD}"
export LD_PRELOAD
break
fi
done

# Show packages info if DEBUG env variable is set
if [ "$DEBUG" = 1 ]; then
cat ${HERE}/packages.txt
Expand Down
15 changes: 15 additions & 0 deletions package/rattler-build/linux/create_bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,21 @@ export FONTCONFIG_PATH=/etc/fonts
# Fix: Use X to run on Wayland
export QT_QPA_PLATFORM=xcb

# The AppImage bundles libdrm_amdgpu from its build environment. On current
# Arch/Mesa systems that copy can make Qt's GLX probe see no framebuffer
# configurations. Preload the host-matched library when AMD hardware is
# present; the loader then reuses it instead of the bundled copy.
drm_root=${VIBECAD_DRM_ROOT:-/sys/class/drm}
libdrm_amdgpu=${VIBECAD_LIBDRM_AMDGPU:-/usr/lib/libdrm_amdgpu.so.1}
for vendor_path in "$drm_root"/card*/device/vendor; do
[ -r "$vendor_path" ] || continue
if [ "$(cat "$vendor_path")" = "0x1002" ] && [ -r "$libdrm_amdgpu" ]; then
LD_PRELOAD="$libdrm_amdgpu${LD_PRELOAD:+:$LD_PRELOAD}"
export LD_PRELOAD
break
fi
done

# Show packages info if DEBUG env variable is set
if [ "$DEBUG" = 1 ]; then
cat ${HERE}/packages.txt
Expand Down
84 changes: 84 additions & 0 deletions src/Tools/tests/test_linux_appimage_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
# SPDX-License-Identifier: LGPL-2.1-or-later

import os
import re
import stat
import subprocess
import tempfile
import unittest
from pathlib import Path


REPO_ROOT = Path(__file__).resolve().parents[3]
CREATE_BUNDLE = REPO_ROOT / "package" / "rattler-build" / "linux" / "create_bundle.sh"
TRACKED_LAUNCHER = REPO_ROOT / "package" / "rattler-build" / "linux" / "AppDir" / "AppRun"


def generated_launcher() -> str:
match = re.search(
r"cat > AppDir/AppRun <<'EOF'\n(?P<body>.*?)\nEOF",
CREATE_BUNDLE.read_text(encoding="utf-8"),
flags=re.DOTALL,
)
if not match:
raise AssertionError("Linux bundle script has no AppRun heredoc")
return match.group("body") + "\n"


class TestLinuxAppImageLauncher(unittest.TestCase):
def test_generated_launcher_matches_tracked_launcher(self) -> None:
self.assertEqual(
generated_launcher(),
TRACKED_LAUNCHER.read_text(encoding="utf-8"),
)

def test_amd_host_library_precedes_bundled_libdrm(self) -> None:
with tempfile.TemporaryDirectory() as temp_dir:
root = Path(temp_dir)
appdir = root / "AppDir"
binary = appdir / "usr" / "bin" / "freecad"
vendor = root / "drm" / "card0" / "device" / "vendor"
host_library = root / "libdrm_amdgpu.so.1"
output = root / "environment.txt"
fake_bin = root / "bin"

binary.parent.mkdir(parents=True)
vendor.parent.mkdir(parents=True)
fake_bin.mkdir()
launcher = appdir / "AppRun"
launcher.write_text(generated_launcher(), encoding="utf-8")
binary.write_text(
'#!/bin/sh\nprintf "%s\\n" "${LD_PRELOAD-}" > "$VIBECAD_TEST_OUTPUT"\n',
encoding="utf-8",
)
(fake_bin / "readlink").write_text(
'#!/bin/sh\nif [ "$1" = "-f" ]; then '
'cd "$(dirname "$2")" && printf "%s/%s\\n" "$PWD" "$(basename "$2")"; '
"else /usr/bin/readlink \"$@\"; fi\n",
encoding="utf-8",
)
vendor.write_text("0x1002\n", encoding="utf-8")
host_library.touch()
for executable in (launcher, binary, fake_bin / "readlink"):
executable.chmod(executable.stat().st_mode | stat.S_IXUSR)

environment = os.environ.copy()
environment.update(
{
"PATH": f"{fake_bin}:{environment['PATH']}",
"LD_PRELOAD": "existing.so",
"VIBECAD_DRM_ROOT": str(root / "drm"),
"VIBECAD_LIBDRM_AMDGPU": str(host_library),
"VIBECAD_TEST_OUTPUT": str(output),
}
)
subprocess.run([str(launcher)], env=environment, check=True)

self.assertEqual(
output.read_text(encoding="utf-8").strip(),
f"{host_library}:existing.so",
)


if __name__ == "__main__":
unittest.main()
Loading