Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fixes #4061

Merged
merged 43 commits into from
Jan 31, 2025
Merged

Lint fixes #4061

merged 43 commits into from
Jan 31, 2025

Conversation

oscarssanchezz
Copy link
Contributor

@oscarssanchezz oscarssanchezz commented Jan 16, 2025

Description of the Change

  • Introduces a global color CSS file to reuse common colors on different stylesheets.
  • Fixes PHP lint issues
  • Fixes JS lint issues
  • Fixes Style lint issues

Closes #4041

How to test the Change

Linting:

Run

  • composer run lint
  • npm run lint-js
  • npm run lint-style

All of them should pass.

ElasticPress functionality

  • Functionality should be the same, with minor visual changes.

Changelog Entry

Developer - PHP, JS and Style lint fixes.
Changed - ElasticPress\Feature\RelatedPosts::get_related_query(), ElasticPress\Feature\RelatedPosts::find_related() parameter name change to $post_return

Credits

Props @oscarssanchezz, @felipeelia

Checklist:

@oscarssanchezz oscarssanchezz changed the title WIP: Lint fixes Lint fixes Jan 22, 2025
@oscarssanchezz oscarssanchezz added this to the 5.2.0 milestone Jan 22, 2025
assets/css/instant-results.css Outdated Show resolved Hide resolved
assets/css/instant-results/range-slider.css Outdated Show resolved Hide resolved
assets/css/instant-results/sort.css Outdated Show resolved Hide resolved
assets/css/woocommerce/admin/components/combobox.css Outdated Show resolved Hide resolved
includes/classes/Command.php Outdated Show resolved Hide resolved
includes/classes/Indexable/Post/QueryIntegration.php Outdated Show resolved Hide resolved
includes/classes/Indexable/Post/QueryIntegration.php Outdated Show resolved Hide resolved
@oscarssanchezz oscarssanchezz merged commit 95726c4 into develop Jan 31, 2025
23 checks passed
@oscarssanchezz oscarssanchezz deleted the fix/4041-linting branch January 31, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP and JS lint
3 participants