Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fixes #4061

Merged
merged 43 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
b789ac0
Show real linting issues
oscarssanchez Jan 16, 2025
406fa44
Fix linting errors in plugin files
oscarssanchez Jan 17, 2025
472bdea
Compiled CSS does not contain @import/@nest
oscarssanchez Jan 18, 2025
b501e28
Resolve JS lint issues
oscarssanchez Jan 18, 2025
f9d98ff
Resolves linting issues in test files
oscarssanchez Jan 18, 2025
5772766
Resolves lint issue with unused variable
oscarssanchez Jan 18, 2025
d5ebaf9
Simplify #fff color in favor of global
oscarssanchez Jan 22, 2025
a639828
Simplify #eee color in favor of global
oscarssanchez Jan 22, 2025
e6881f9
Simplify #626262 color in favor of global
oscarssanchez Jan 22, 2025
e1c325d
Simplify #f9f9f9 color in favor of global
oscarssanchez Jan 22, 2025
9693685
Simplify #efefef color in favor of global
oscarssanchez Jan 22, 2025
0adaae2
Simplify #d84440 color in favor of global
oscarssanchez Jan 22, 2025
7d6ea09
Simplify #d73c38 color in favor of global
oscarssanchez Jan 22, 2025
bbabee9
Simplify #b93431 color in favor of global
oscarssanchez Jan 22, 2025
4f45cff
Simplify #999 color in favor of global
oscarssanchez Jan 22, 2025
6139e37
Simplify #0073aa color in favor of global
oscarssanchez Jan 22, 2025
a1f986c
Simplify #5e5e5e color in favor of global
oscarssanchez Jan 22, 2025
f9e5f80
Simplify #8c8f94 color in favor of global
oscarssanchez Jan 22, 2025
1c7fd3d
Simplify #666 color in favor of global
oscarssanchez Jan 22, 2025
f5e0fb5
Simplify #000 color in favor of global
oscarssanchez Jan 22, 2025
81d0120
Simplify #aaa color in favor of global
oscarssanchez Jan 22, 2025
2558d02
Simplify #bbb color in favor of global
oscarssanchez Jan 22, 2025
86493a7
Simplify #72777c color in favor of global
oscarssanchez Jan 22, 2025
4dd3eeb
Simplify #ccc color in favor of global
oscarssanchez Jan 22, 2025
0d05c4b
Simplify #ffe8ed color in favor of global
oscarssanchez Jan 22, 2025
3be4d8b
Simplify #fdeeca color in favor of global
oscarssanchez Jan 22, 2025
ea8131a
Add color globals
oscarssanchez Jan 22, 2025
54d2994
Consolidate status colors
oscarssanchez Jan 22, 2025
c051e3d
Resolves path issue
oscarssanchez Jan 22, 2025
7f7a658
Resolve @nest lint issues
oscarssanchez Jan 22, 2025
d67ee18
Resolve currentcolor warning
oscarssanchez Jan 22, 2025
dbf0639
Add back methods to prevent fatal for users
oscarssanchez Jan 22, 2025
79aa55c
Merge branch 'develop' into fix/4041-linting
oscarssanchezz Jan 22, 2025
7aea73a
Remove extra space
oscarssanchez Jan 24, 2025
3e75bd0
Merge branch 'fix/4041-linting' of github.com:10up/ElasticPress into …
oscarssanchez Jan 24, 2025
85bcf30
Remove extra line
oscarssanchez Jan 24, 2025
4a1a723
Remove additional var call
oscarssanchez Jan 24, 2025
f6a34bb
Remove add_action arg parameter
oscarssanchez Jan 24, 2025
e8af197
Restore parameter for retrocompatibility
oscarssanchez Jan 24, 2025
600d631
Remove filter unused parameter
oscarssanchez Jan 24, 2025
f3dcd62
Merge branch 'develop' into fix/4041-linting
felipeelia Jan 28, 2025
d7d45e7
Merge branch 'develop' into fix/4041-linting
oscarssanchezz Jan 30, 2025
58052cb
Change ignore ruleset
oscarssanchez Jan 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ jobs:
run: composer install

- name: PHPCS check
run: './vendor/bin/phpcs . -q --report=checkstyle --warning-severity=6 --runtime-set testVersion 7.4- | cs2pr'
run: './vendor/bin/phpcs . -q --report=checkstyle --runtime-set testVersion 7.4- | cs2pr'
29 changes: 14 additions & 15 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
{
"extends": [
"@10up/stylelint-config"
],
"rules": {
"scale-unlimited/declaration-strict-value": [
"/color/",
{
"ignoreValues": ["currentColor", "inherit", "initial", "transparent", "unset"],
"severity": "warning"
}
],
"font-family-no-missing-generic-family-keyword": null,
"declaration-property-unit-allowed-list": null,
"at-rule-disallowed-list": null
}
"extends": [
"@10up/stylelint-config"
],
"rules": {
"scale-unlimited/declaration-strict-value": [
"/color/",
{
"ignoreValues": ["currentcolor", "inherit", "initial", "transparent", "unset"],
"severity": "warning"
}
],
"font-family-no-missing-generic-family-keyword": null,
"declaration-property-unit-allowed-list": null
}

}
12 changes: 7 additions & 5 deletions assets/css/autosuggest.css
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
@import "./global/colors.css";

.ep-autosuggest-container {
position: relative;

& .ep-autosuggest {
background: #fff;
border: 1px solid #ccc;
background: var(--ep-c-white);
border: 1px solid var(--ep-c-white-gray);
box-shadow: 0 2px 4px rgba(0, 0, 0, 0.2);
display: none;
position: absolute;
Expand All @@ -19,14 +21,14 @@
font-family: sans-serif;

& > a.autosuggest-link {
color: #000;
color: var(--ep-c-black);
cursor: pointer;
display: block;
padding: 2px 10px;

&:hover,
&:active {
background-color: #eee;
background-color: var(--ep-c-medium-white);
text-decoration: none;
}
}
Expand All @@ -35,7 +37,7 @@
}

& .selected {
background-color: #eee;
background-color: var(--ep-c-medium-white);
text-decoration: none;
}
}
Loading