Skip to content

Conversation

@iinuwa
Copy link
Contributor

@iinuwa iinuwa commented Oct 12, 2025

Upstreaming bitwarden#14:

Make the typeshare dependency optional since it's generally not required. Due to some rust limitations I had to duplicate two struct fields.

@iinuwa iinuwa force-pushed the bitwarden/typeshare-optional branch from 106150e to 2debb54 Compare October 14, 2025 18:30
Copy link
Collaborator

@Progdrasil Progdrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, You'll just need to fix the pipeline

@iinuwa iinuwa force-pushed the bitwarden/typeshare-optional branch from 2debb54 to 1c87f46 Compare October 15, 2025 17:40
@iinuwa
Copy link
Contributor Author

iinuwa commented Oct 15, 2025

Looks like we need to duplicate those two fields mentioned in the review because the typeshare field attribute is a macro attribute, but cfg_attr only supports non-macro attributes. (This is different from serde, whose struct attributes is a macro attribute, but the field attributes are non-macro attributes.)

I reverted back to the original code. I'll do a separate PR to fix the Clippy lints.

@Progdrasil
Copy link
Collaborator

For the cfg_attr, this will be blocked on 1Password/typeshare#273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants