-
Notifications
You must be signed in to change notification settings - Fork 117
allow cfg attr typeshare -> typeshare2 #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow cfg attr typeshare -> typeshare2 #273
Conversation
57eaecf to
e27fbec
Compare
610c8a4 to
727040e
Compare
727040e to
2b5e06a
Compare
b39c251 to
a59412b
Compare
Progdrasil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works perfectly for 1Password/passkey-rs#68
8141de6 to
0b44d4a
Compare
0b44d4a to
60087a4
Compare
smcgovern-proj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM and works locally (with the caveat that I'm not the most familiar with syn as a lib/syn-related idioms.) Thanks a bunch for making the QOL improvements like doc comments + logger.
Using typeshared types may be behind a feature and as such the annotation would be something like
#[cfg_attr(feature = "typeshare-support", typeshare)].This PR adds support for generating typeshare types using a
cfg_attrcondition.I'll be adding this to #274 then porting it back into typeshare2
Other changes: