Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider partial index creation as making a column not nullable. #258

Conversation

David-Wobrock
Copy link
Collaborator

Fixes #250

@David-Wobrock David-Wobrock self-assigned this Jul 3, 2023
@David-Wobrock David-Wobrock marked this pull request as ready for review July 3, 2023 18:37
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (366d16b) 93.94% compared to head (02cabab) 93.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   93.94%   93.95%           
=======================================
  Files          77       77           
  Lines        1966     1969    +3     
=======================================
+ Hits         1847     1850    +3     
  Misses        119      119           
Impacted Files Coverage Δ
django_migration_linter/sql_analyser/base.py 100.00% <ø> (ø)
tests/unit/test_sql_analyser.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@David-Wobrock David-Wobrock merged commit 97a1f5c into main Jul 3, 2023
@David-Wobrock David-Wobrock deleted the 250-adding-an-index-with-a-not-null-condition-incorrectly-triggers-not_null-rule branch July 3, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an index with a NOT NULL condition incorrectly triggers NOT_NULL rule
2 participants