🎨 Palette: Improve keyboard focus parity for links#73
🎨 Palette: Improve keyboard focus parity for links#73NickJLange wants to merge 1 commit intomainfrom
Conversation
💡 What: Added `group-focus-visible` classes to icons inside links that already had `group-hover` classes. Also updated the `ExternalLinkIcon` to use `role="img"` and `aria-label`. 🎯 Why: Keyboard users were missing out on the visual feedback (arrow movement) that mouse users received when hovering over links. Screen reader users were reading the external link icon as hidden instead of understanding it opens in a new tab. ♿ Accessibility: Ensures WCAG 2.1 SC 2.4.7 Focus Visible and proper ARIA labeling for icons. Co-authored-by: NickJLange <1529105+NickJLange@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎨 Palette: Improve keyboard focus parity for links
💡 What: Added
group-focus-visibleclasses to icons inside links that already hadgroup-hoverclasses. Also updated theExternalLinkIconto userole="img"andaria-label.🎯 Why: Keyboard users were missing out on the visual feedback (arrow movement) that mouse users received when hovering over links. Screen reader users were reading the external link icon as hidden instead of understanding it opens in a new tab.
♿ Accessibility: Ensures WCAG 2.1 SC 2.4.7 Focus Visible and proper ARIA labeling for icons.
PR created automatically by Jules for task 2257518612006641883 started by @NickJLange