Skip to content

🎨 Palette: Improve keyboard focus parity for links #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickJLange wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve keyboard focus parity for links #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,7 @@
## 2026-02-18 - External Link Indicators
**Learning:** Exposing hidden content & using distinct indicators for external links improves discoverability and sets clear expectations.
**Action:** Use an `ExternalLinkIcon` (e.g., arrow up-right) for external links in lists to differentiate them from internal navigation.

## 2026-03-08 - Keyboard parity for hover interactions
**Learning:** Adding animation classes only to hover states (e.g., `group-hover:translate-x-1`) means keyboard users miss out on visual interaction feedback when focusing on links or buttons.
**Action:** Always pair `hover` or `group-hover` interactive classes with equivalent `focus-visible` or `group-focus-visible` classes to ensure equitable visual feedback for keyboard navigation.
11 changes: 6 additions & 5 deletions src/components/HomepageContent/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ function ExternalLinkIcon({ className }) {
strokeLinecap="round"
strokeLinejoin="round"
className={className}
aria-hidden="true"
role="img"
aria-label="(opens in new tab)"
>
<path d="M18 13v6a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h6" />
<polyline points="15 3 21 3 21 9" />
Expand All @@ -63,9 +64,9 @@ function Section({ title, items }) {
<Link to={item.link} className="inline-flex items-center gap-1 group">
{item.title}
{isExternal ? (
<ExternalLinkIcon className="transition-transform group-hover:translate-x-1 group-hover:-translate-y-1" />
<ExternalLinkIcon className="transition-transform group-hover:translate-x-1 group-hover:-translate-y-1 group-focus-visible:translate-x-1 group-focus-visible:-translate-y-1" />
) : (
<ArrowIcon className="transition-transform group-hover:translate-x-1" />
<ArrowIcon className="transition-transform group-hover:translate-x-1 group-focus-visible:translate-x-1" />
)}
</Link>
) : (
Expand Down Expand Up @@ -95,7 +96,7 @@ function LatestPost() {
<h3>
<Link to={latestPost.url} className="inline-flex items-center gap-1 group">
{latestPost.title}
<ArrowIcon className="transition-transform group-hover:translate-x-1" />
<ArrowIcon className="transition-transform group-hover:translate-x-1 group-focus-visible:translate-x-1" />
</Link>
</h3>
<small>
Expand All @@ -119,7 +120,7 @@ function LatestPost() {
aria-label={`Read more about ${latestPost.title}`}
>
Read More
<ArrowIcon className="transition-transform group-hover:translate-x-1" />
<ArrowIcon className="transition-transform group-hover:translate-x-1 group-focus-visible:translate-x-1" />
</Link>
</div>
</div>
Expand Down
Loading