Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German translation #176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devmarcstorm
Copy link
Contributor

@devmarcstorm devmarcstorm commented Feb 9, 2025

Description

I have added a translations/de.json to support the German language in mushroom-strategy, imported the file into localize.ts and added de to the registry of supported languages. Closes #175

Type of Change

Put an x in all boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Hot fix (corrects a major software bug or fault and should released as quickly as possible.)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring
  • Security patch
  • UI/UX improvement

Testing

I have recompiled the mushroom-strategy.js and checked on my Home Assistant instance that the translations are applied.

Impact

No effects other than the appearance of German translations in the elements generated by mushroom-strategy.

Additional Information

Exemplary screenshot of the headers for “Leuchten” and “Schalter.” Control elements for switching the groups off and on are located next to the titles.

Checklist

Put an x in all boxes that apply

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@DigiLive DigiLive added this to the Release v2.2.0 milestone Feb 16, 2025
@DigiLive DigiLive added enhancement New feature or request In Progress Someone is already working on it. labels Feb 16, 2025
@DigiLive
Copy link
Collaborator

@devmarcstorm
Copy link
Contributor Author

@DigiLive Yes, it'll be done in the next few hours.

@devmarcstorm
Copy link
Contributor Author

@DigiLive Done

@DigiLive
Copy link
Collaborator

Thanks. I'll merge the PR after #164

@DigiLive DigiLive mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In Progress Someone is already working on it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Add German translation
2 participants