Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth - Ana #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Earth - Ana #51

wants to merge 5 commits into from

Conversation

anakp07
Copy link

@anakp07 anakp07 commented Dec 15, 2020

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? A lot of things were similar to Ruby minus the syntax.
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? No I just did what I would do for Ruby, look at documentation, videos, etc.
What was something you needed to do independent research on for this project? What did you learn? Looking at how to use slice.
What was a challenge you were able to overcome on this assignment? Completing almost all of the waves.
What has been interesting and positive about learning a new programming language? Jest is cool for testing, it offers insight.
What is something to focus on your learnings in JavaScript in the next week? Understanding closures and using Classes.

// Wave two
usesAvailableLetters(input,lettersInHand ){
let validWord = true;
let userWord = input.toUpperCase().split('');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one example I see where let is used when const could've been used instead, so great job with that overall!

}
})
return validWord;
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing: This should be indented two spaces less

@jmaddox19
Copy link

JS Adagrams

Great work! The code looks great! There are just a couple minor things I that could be improved, noted in inline comments. So glad you are getting so comfortable with JS already!!

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var. ✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase. ✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures ✔️

Functional Requirements

Functional Requirement yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass ✔️
Utilizes unit tests to verify code; all tests for scoreWord pass ✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants