forked from AdaGold/js-adagrams
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earth - Ana #51
Open
anakp07
wants to merge
5
commits into
Ada-C14:master
Choose a base branch
from
anakp07:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Earth - Ana #51
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
49b4a4b
working on wave 1
f80cdf2
created the drawLetters function for Wave 1, test is passing
1c7f375
created the usesAvailableLetters function, test passed
0a50a66
created the scoreWord function, test passed
4f07915
Waves 1,2 and 3 are complete and passing
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,75 @@ | ||
const letterPool = { | ||
A: 9,B: 2,C: 2,D: 4,E: 12,F: 2,G: 3,H: 2,I: 9,J: 1, K: 1,L: 4,M: 2, | ||
N: 6,O: 8,P: 2,Q: 1,R: 6,S: 4,T: 6, U: 4,V: 2,W: 2,X: 1,Y: 2,Z: 1 | ||
}; | ||
|
||
const letterScore = { | ||
A: 1, E: 1, I: 1, O: 1, U: 1, L: 1, N: 1, R: 1, S: 1, T: 1, | ||
D: 2, G: 2, | ||
B: 3, C: 3, M: 3, P: 3, | ||
F: 4, H: 4, V: 4, W: 4, Y: 4, | ||
K: 5, | ||
J: 8, X: 8, | ||
Q: 10, Z: 10 | ||
}; | ||
|
||
const Adagrams = { | ||
|
||
// Wave one | ||
|
||
drawLetters() { | ||
// Implement this method for wave 1 | ||
const letterPoolArray = []; | ||
|
||
for(const letter in letterPool){ | ||
for(let i = 0; i < letterPool[letter]; i++) { | ||
letterPoolArray.push(letter); | ||
} | ||
} | ||
|
||
const hand = []; | ||
|
||
for(let i = 0; i < 10; i++){ | ||
const randomLetters = letterPoolArray[Math.floor(Math.random() * letterPoolArray.length)]; | ||
hand.push(randomLetters); | ||
} | ||
return hand; | ||
}, | ||
}; | ||
|
||
// Wave two | ||
usesAvailableLetters(input,lettersInHand ){ | ||
let validWord = true; | ||
let userWord = input.toUpperCase().split(''); | ||
|
||
userWord.forEach((char) => { | ||
let index = lettersInHand.indexOf(char); | ||
|
||
if(index === -1) { | ||
validWord = false; | ||
} else { | ||
lettersInHand.splice(index,1) | ||
} | ||
}) | ||
return validWord; | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor thing: This should be indented two spaces less |
||
|
||
// Wave Three | ||
|
||
scoreWord(word) { | ||
let score = 0 | ||
for(const letter of word.toUpperCase().split('')){ | ||
score += letterScore[letter]; | ||
} | ||
if (word.length >= 7) { | ||
score += 8; | ||
} | ||
return score; | ||
}, | ||
//Wave 4 | ||
|
||
// highestScoreFrom(words) | ||
|
||
|
||
} | ||
|
||
// Do not remove this line or your tests will break! | ||
export default Adagrams; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one example I see where
let
is used whenconst
could've been used instead, so great job with that overall!