Earth - Ana #51
Open
Earth - Ana #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaddox19
reviewed
Dec 17, 2020
| // Wave two | ||
| usesAvailableLetters(input,lettersInHand ){ | ||
| let validWord = true; | ||
| let userWord = input.toUpperCase().split(''); |
There was a problem hiding this comment.
This is the one example I see where let is used when const could've been used instead, so great job with that overall!
| } | ||
| }) | ||
| return validWord; | ||
| }, |
There was a problem hiding this comment.
Minor thing: This should be indented two spaces less
JS AdagramsGreat work! The code looks great! There are just a couple minor things I that could be improved, noted in inline comments. So glad you are getting so comfortable with JS already!! Major Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: JS Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection