sso: Make discoveryProtocol attribute removable #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting a discoveryProtocol if a single IdP is used leads to the following error: "ERROR Shibboleth.Application : SSO discoveryProtocol specified without discoveryURL" Therefore the discoveryProtocol attribute has to be removable. Overriding the default parameter $::shibboleth::params::discovery_protocol with undef and applying a similar logic as for $discoveryURL and $idpURL does not work. The reason is explained in https://tickets.puppetlabs.com/browse/PUP-5295 "The semantics of giving undef as an argument to a resource (class or other) is that the result is the default value of that parameter." For this reason the value "none" was introduced for the $discovery_protocol parameter to indicate removal of this attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a discoveryProtocol if a single IdP is used leads to the
following error:
"ERROR Shibboleth.Application : SSO discoveryProtocol specified without
discoveryURL"
Therefore the discoveryProtocol attribute has to be removable. Overriding
the default parameter $::shibboleth::params::discovery_protocol with undef
and applying a similar logic as for $discoveryURL and $idpURL does not
work. The reason is explained in
https://tickets.puppetlabs.com/browse/PUP-5295
"The semantics of giving undef as an argument to a resource (class or
other) is that the result is the default value of that parameter."
For this reason the value "none" was introduced for the
$discovery_protocol parameter to indicate removal of this attribute.