Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sso: Make discoveryProtocol attribute removable #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sso: Make discoveryProtocol attribute removable #15

wants to merge 1 commit into from

Commits on Jan 28, 2020

  1. sso: Make discoveryProtocol attribute removable 

    Setting a discoveryProtocol if a single IdP is used leads to the
following error:

"ERROR Shibboleth.Application : SSO discoveryProtocol specified without
discoveryURL"

Therefore the discoveryProtocol attribute has to be removable. Overriding
the default parameter $::shibboleth::params::discovery_protocol with undef
and applying a similar logic as for $discoveryURL and $idpURL does not
work. The reason is explained in

https://tickets.puppetlabs.com/browse/PUP-5295

"The semantics of giving undef as an argument to a resource (class or
other) is that the result is the default value of that parameter."

For this reason the value "none" was introduced for the
$discovery_protocol parameter to indicate removal of this attribute.
    @wiene
    wiene committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    60447d9 View commit details
    Browse the repository at this point in the history