build: Downgrade execa to 9.1.0 for Node.js 18.18 support #10500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
262f970
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://03871c1f.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-bump-node.agoric-sdk.pages.dev |
turadg
reviewed
Nov 15, 2024
.github/workflows/integration.yml
Outdated
| @@ -135,8 +135,7 @@ jobs: | |||
| path: ./agoric-sdk | |||
| - uses: ./agoric-sdk/.github/actions/restore-node | |||
| with: | |||
| # XXX loadgen not compatible with 18.19 https://github.com/Agoric/agoric-sdk/pull/8365#issuecomment-1848003597 | |||
There was a problem hiding this comment.
pretty sure this was legit https://github.com/Agoric/agoric-sdk/actions/runs/11863590746/job/33065361760?pr=10500
There was a problem hiding this comment.
Damn. Then I guess the right fix is instead downgrading execa to e.g. ^9.3.1?
There was a problem hiding this comment.
This is the fix I'd really like to see =)
But downgrading execa makes sense for now.
gibson042
changed the title
turadg
approved these changes
Nov 16, 2024
gibson042
added a commit
to Agoric/agoric-3-proposals
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Version ^18.19.0 is required by execa 9.5.1 (which we already use in fast-usdc and a3p-integration/proposals/n:upgrade-next): https://github.com/Agoric/agoric-sdk/actions/runs/11863279067/job/33064414447?pr=10499#step:4:270
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.19.0 || >=20.5.0". Got "18.18.2"...and is the LTS version anyway.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
There was a comment from last year about Node.js v18.19 incompatibility; integration testing will reveal if it has in fact been resolved.
Upgrade Considerations
It might be time to bump the Node.js ^18.12 prerequisite.