Skip to content

build: Downgrade execa to 9.1.0 for Node.js 18.18 support #10500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2024
Merged

build: Downgrade execa to 9.1.0 for Node.js 18.18 support #10500

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f623366
build: Bump Node.js to 18.20 for integration testing
gibson042 Nov 15, 2024
2ca3f6c
fixup! build: Bump Node.js to 18.20 for integration testing
gibson042 Nov 15, 2024
c415e4b
fixup! build: Bump Node.js to 18.20 for integration testing
gibson042 Nov 15, 2024
2a8bb3c
build: Restore use of Node.js v18.18
gibson042 Nov 15, 2024
262f970
build: Downgrade execa to 9.1.0 for Node.js 18.18 support
gibson042 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
# Prerequisites
- uses: ./.github/actions/restore-node
with:
node-version: 18.18
node-version: '18.20'
keep-endo: 'true'

# Select a branch of the
Expand Down Expand Up @@ -135,8 +135,7 @@ jobs:
path: ./agoric-sdk
- uses: ./agoric-sdk/.github/actions/restore-node
with:
# XXX loadgen not compatible with 18.19 https://github.com/Agoric/agoric-sdk/pull/8365#issuecomment-1848003597
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this was legit https://github.com/Agoric/agoric-sdk/actions/runs/11863590746/job/33065361760?pr=10500

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. Then I guess the right fix is instead downgrading execa to e.g. ^9.3.1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix I'd really like to see =)

But downgrading execa makes sense for now.

node-version: 18.18
node-version: '18.20'
path: ./agoric-sdk
# Forces xsnap to initialize all memory to random data, which increases
# the chances the content of snapshots may deviate between validators
Expand Down
Loading