Fixed e2e makefile target to use deploy-cli instead of deploy-script.js #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jovonni
changed the title
Jovonni
changed the title
|
Nice, would be great to close out #72 here or in a fast follow |
dckc
requested changes
Oct 3, 2024
contract/Makefile
Outdated
| # todo: figure out why this sequence # is always off by 1 forcing a retry | ||
| # yarn node script/deploy-contract.js | ||
|
|
||
| npx tsx ../e2e-testing/scripts/deploy-cli.ts test/builder/init-orca.js |
There was a problem hiding this comment.
npx by itself is a bit of a loose cannon. Be sure to use --no-install.
Suggested change
| npx tsx ../e2e-testing/scripts/deploy-cli.ts test/builder/init-orca.js | |
| npx --no-install tsx ../e2e-testing/scripts/deploy-cli.ts test/builder/init-orca.js |
consider factoring it out a la...
and then...
Suggested change
| npx tsx ../e2e-testing/scripts/deploy-cli.ts test/builder/init-orca.js | |
| $(TSX) ../e2e-testing/scripts/deploy-cli.ts test/builder/init-orca.js |
There was a problem hiding this comment.
you could even go further...
Suggested change
| npx tsx ../e2e-testing/scripts/deploy-cli.ts test/builder/init-orca.js | |
| $(DEPLOY) test/builder/init-orca.js |
There was a problem hiding this comment.
ah good ideas! will do
| @@ -259,26 +259,7 @@ test-orca: | |||
|
|
|||
| # todo remove clean install steps after debugging | |||
| e2e: | |||
| make clean | |||
There was a problem hiding this comment.
👏 for replacing lots of old lines with 1 new one
|
How about deleting |
Jovonni
force-pushed
the
jo/e2e-deployment-fix
branch
from
84a5e1b to
1db90cf
Compare
dckc
approved these changes
Oct 4, 2024
Jovonni
force-pushed
the
jo/e2e-deployment-fix
branch
from
c344d92 to
da643e4
Compare
amessbee
approved these changes
Oct 4, 2024
| # todo: figure out why this sequence # is always off by 1 forcing a retry | ||
| # yarn node script/deploy-contract.js | ||
|
|
||
| $(DEPLOY) src/builder/init-orca.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
deploy-contract.jsis now "subsumed" bydeploy-cli.js, we replace the Makefile target:New command to deploy:
$(DEPLOY) src/builder/init-orca.jswhich expands to:
npx --no-install tsx ../e2e-testing/scripts/deploy-cli.ts src/builder/init-orca.jsFixes #77 , renders #64 outdated, and addresses #72
Shoutout to @dckc & @0xpatrickdev for the heads up!
@amessbee try this now, should be good 🚀