Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed e2e makefile target to use deploy-cli instead of deploy-script.js #78

Merged
merged 4 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions contract/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ VOTE_OPTION=yes
CLIENTADDR=agoric12j5kzvrwunqvrga5vm4zpy3mkeh3lvyld0amz5
CLIENT_OSMO_ADDR=osmo1rhvgsqq96n3qyv3u0zlwleyaunpmal6uhnam4z

DEPLOY=npx --no-install tsx ../e2e-testing/scripts/deploy-cli.ts

.PHONY: list
# https://stackoverflow.com/a/73159833/7963
list:
Expand Down Expand Up @@ -259,26 +261,7 @@ test-orca:

# todo remove clean install steps after debugging
e2e:
make clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 for replacing lots of old lines with 1 new one

make cleanc
yarn cache clean
kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "yarn cache clean"
kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "rm -rf -v /root/*"
# yarn run build:deployer
make copy-project
kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "cd /root/ ; yarn install"
kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "cd /root/ ; yarn add @endo/[email protected]"
#kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "cd /root/ ; yarn add @agoric/[email protected]"
kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "cd /root/ ; yarn add @agoric/[email protected]"
kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "cd /root/ ; yarn add @agoric/[email protected]"
kubectl exec -i agoriclocal-genesis-0 -c validator -- bash -c "cd /root/ ; yarn build:deployer"

# yarn node scripts/deploy-contract.js --install /root/src/orca.contract.js --eval /root/src/orca.proposal.js
yarn node scripts/deploy-contract.js --install ${PWD}/src/orca.contract.js,${PWD}/src/orca.proposal.js --eval /root/src/orca.proposal.js

# todo: figure out why this sequence # is always off by 1 forcing a retry
# yarn node script/deploy-contract.js

$(DEPLOY) src/builder/init-orca.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

lint:
yarn lint --fix-dry-run --ignore-pattern "*patch*"

131 changes: 0 additions & 131 deletions contract/scripts/deploy-contract.js

This file was deleted.

File renamed without changes.
2 changes: 1 addition & 1 deletion contract/test/orca-multichain.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const configFile = nodeRequire.resolve('../../e2e-testing/config.yaml');
const test = anyTest;

const contractName = 'orca';
const contractBuilder = './test/builder/init-orca.js';
const contractBuilder = './src/builder/init-orca.js';

const makeTestContext = async t => {
t.log('configure starship regisry', configFile);
Expand Down
2 changes: 1 addition & 1 deletion contract/tools/e2e-tools.js
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ export const makeE2ETools = (
// generate plan, etc
// const keyring = await makeKeyring(tools);
// const deployBuilder = makeDeployBuilder(tools, fse.readJSON, execa);
const contractBuilder = './test/builder/init-orca.js';
const contractBuilder = './src/builder/init-orca.js';
// await deployBuilder(contractBuilder);
const { stdout } = await execa`agoric run ${contractBuilder}`;
const match = stdout.match(/ (?<name>[-\w]+)-permit.json/);
Expand Down
Loading