Skip to content

Create config file and pass to l7 proxy#452

Open
SanderDeclerck wants to merge 3 commits into
rama-integration-betafrom
rama-configuration
Open

Create config file and pass to l7 proxy#452
SanderDeclerck wants to merge 3 commits into
rama-integration-betafrom
rama-configuration

Conversation

@SanderDeclerck
Copy link
Copy Markdown
Collaborator

@SanderDeclerck SanderDeclerck commented May 8, 2026

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 1 Resolved Issues: 0

🚀 New Features

  • Created Aikido endpoint config file and passed it to proxy

⚡ Enhancements

  • Simplified reporting server block handling and emitted consistent events

More info

id: 1,
name: "Default",
},
ecosystems: {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm and pypi blocks in getConfigContent() are near-identical; consolidate to a single generator to avoid duplicated config logic (e.g., a helper that builds an ecosystem entry using cutoff).

Details

✨ AI Reasoning
​The new module builds a JSON config with two ecosystem entries (npm and pypi) that are structurally and logically identical: same keys and same values computed from cutoff. This duplicates non-trivial configuration logic within the same function and file, increasing maintenance burden because updates to one ecosystem’s config would need to be mirrored in the other.

🔧 How do I fix it?
Delete extra code. Extract repeated code sequences into reusable functions or methods. Use loops or data structures to eliminate repetitive patterns.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant