-
Notifications
You must be signed in to change notification settings - Fork 84
Create config file and pass to l7 proxy #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SanderDeclerck
wants to merge
3
commits into
rama-integration-beta
Choose a base branch
from
rama-configuration
base: rama-integration-beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+109
β1
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
93 changes: 93 additions & 0 deletions
93
packages/safe-chain/src/registryProxy/ramaProxy/createAikidoEndpointConfigFile.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| import { writeFile } from "fs"; | ||
| import { join } from "path/posix"; | ||
| import { promisify } from "util"; | ||
| import { | ||
| getMinimumPackageAgeHours, | ||
| skipMinimumPackageAge, | ||
| } from "../../config/settings.js"; | ||
|
|
||
| /** | ||
| * | ||
| * @param {string} dataFolder | ||
| * @returns string | ||
| */ | ||
| export async function createAikidoEndpointConfigFile(dataFolder) { | ||
| const configPath = join(dataFolder, "safe-chain-config.json"); | ||
|
|
||
| const config = getConfigContent(); | ||
| const configJson = JSON.stringify(config); | ||
|
|
||
| await promisify(writeFile)(configPath, configJson); | ||
|
|
||
| return configPath; | ||
| } | ||
|
|
||
| function getConfigContent() { | ||
| let cutoff = Math.floor(Date.now() / 1000); | ||
|
|
||
| if (!skipMinimumPackageAge()) { | ||
| cutoff = cutoff - (getMinimumPackageAgeHours() * 3600); | ||
| } | ||
|
|
||
| return { | ||
| permission_group: { | ||
| id: 1, | ||
| name: "Default", | ||
| }, | ||
| ecosystems: { | ||
| npm: { | ||
| block_all_installs: false, | ||
| request_installs: false, | ||
| minimum_allowed_age_timestamp: cutoff, | ||
| exceptions: { | ||
| allowed_packages: [], | ||
| rejected_packages: [], | ||
| }, | ||
| }, | ||
| pypi: { | ||
| block_all_installs: false, | ||
| request_installs: false, | ||
| minimum_allowed_age_timestamp: cutoff, | ||
| exceptions: { | ||
| allowed_packages: [], | ||
| rejected_packages: [], | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| /* | ||
|
|
||
| # Reference: config file format. | ||
|
|
||
| ```json | ||
| { | ||
| "permission_group": { | ||
| "id": 18, | ||
| "name": "Default" | ||
| }, | ||
| "ecosystems": { | ||
| "npm": { | ||
| "block_all_installs": false, | ||
| "request_installs": false, | ||
| "minimum_allowed_age_timestamp": 1778143932, | ||
| "exceptions": { | ||
| "allowed_packages": [], | ||
| "rejected_packages": [] | ||
| } | ||
| }, | ||
| "pypi": { | ||
| "block_all_installs": false, | ||
| "request_installs": false, | ||
| "minimum_allowed_age_timestamp": 1778057532, | ||
| "exceptions": { | ||
| "allowed_packages": [], | ||
| "rejected_packages": [] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| */ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The npm and pypi blocks in getConfigContent() are near-identical; consolidate to a single generator to avoid duplicated config logic (e.g., a helper that builds an ecosystem entry using cutoff).
Details
β¨ AI Reasoning
βThe new module builds a JSON config with two ecosystem entries (npm and pypi) that are structurally and logically identical: same keys and same values computed from cutoff. This duplicates non-trivial configuration logic within the same function and file, increasing maintenance burden because updates to one ecosystemβs config would need to be mirrored in the other.
π§ How do I fix it?
Delete extra code. Extract repeated code sequences into reusable functions or methods. Use loops or data structures to eliminate repetitive patterns.
Reply
@AikidoSec feedback: [FEEDBACK]to get better review comments in the future.Reply
@AikidoSec ignore: [REASON]to ignore this issue.More info