Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
import { writeFile } from "fs";
import { join } from "path/posix";
import { promisify } from "util";
import {
getMinimumPackageAgeHours,
skipMinimumPackageAge,
} from "../../config/settings.js";

/**
*
* @param {string} dataFolder
* @returns string
*/
export async function createAikidoEndpointConfigFile(dataFolder) {
const configPath = join(dataFolder, "safe-chain-config.json");

const config = getConfigContent();
const configJson = JSON.stringify(config);

await promisify(writeFile)(configPath, configJson);

return configPath;
}

function getConfigContent() {
let cutoff = Math.floor(Date.now() / 1000);

if (!skipMinimumPackageAge()) {
cutoff = cutoff - (getMinimumPackageAgeHours() * 3600);
}

return {
permission_group: {
id: 1,
name: "Default",
},
ecosystems: {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm and pypi blocks in getConfigContent() are near-identical; consolidate to a single generator to avoid duplicated config logic (e.g., a helper that builds an ecosystem entry using cutoff).

Details

✨ AI Reasoning
​The new module builds a JSON config with two ecosystem entries (npm and pypi) that are structurally and logically identical: same keys and same values computed from cutoff. This duplicates non-trivial configuration logic within the same function and file, increasing maintenance burden because updates to one ecosystem’s config would need to be mirrored in the other.

πŸ”§ How do I fix it?
Delete extra code. Extract repeated code sequences into reusable functions or methods. Use loops or data structures to eliminate repetitive patterns.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

npm: {
block_all_installs: false,
request_installs: false,
minimum_allowed_age_timestamp: cutoff,
exceptions: {
allowed_packages: [],
rejected_packages: [],
},
},
pypi: {
block_all_installs: false,
request_installs: false,
minimum_allowed_age_timestamp: cutoff,
exceptions: {
allowed_packages: [],
rejected_packages: [],
},
},
},
};
}

/*

# Reference: config file format.

```json
{
"permission_group": {
"id": 18,
"name": "Default"
},
"ecosystems": {
"npm": {
"block_all_installs": false,
"request_installs": false,
"minimum_allowed_age_timestamp": 1778143932,
"exceptions": {
"allowed_packages": [],
"rejected_packages": []
}
},
"pypi": {
"block_all_installs": false,
"request_installs": false,
"minimum_allowed_age_timestamp": 1778057532,
"exceptions": {
"allowed_packages": [],
"rejected_packages": []
}
}
}
}
```

*/
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { ui } from "../../environment/userInteraction.js";
import { getLoggingLevel, LOGGING_VERBOSE } from "../../config/settings.js";
import { getReportingServer } from "./reportingServer.js";
import EventEmitter from "node:events";
import { createAikidoEndpointConfigFile } from "./createAikidoEndpointConfigFile.js";

const readFilePromise = promisify(readFile);

Expand Down Expand Up @@ -90,14 +91,16 @@ export function createRamaProxy(ramaPath) {
* @returns {Promise<RamaProxyInstance>}
*/
async function startRama(ramaPath, dataFolder, reportingUrl) {
const startTime = Date.now();
const startTime = Date.now();
const args = [
"--secrets",
"memory",
"--data",
dataFolder,
"--reporting-endpoint",
reportingUrl,
"--config-file",
await createAikidoEndpointConfigFile(dataFolder),
];
const stdio = getLoggingLevel() === LOGGING_VERBOSE ? "inherit" : "pipe";
const process = spawn(ramaPath, args, { stdio: stdio });
Expand Down
Loading