Allow arbitrary expressions in #[ts(export_to)]#399
Merged
gustavo-shigueo merged 4 commits intomainfrom Apr 4, 2025
Merged
Conversation
This was referenced Apr 4, 2025
Closed
Draft
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically @NimonSour's #347 including tests and implemented like #398.
Thanks @NimonSour for the idea & initial implementation!
Docs & Changelog are updated, export-logic remains the same, and unlike #398, everything is 100% backwards-compatible.
Note that this implementation only allows for expressions of whose type implements
Display.That excludes
PathandPathBuf. Some more work would need to be done to accept those as well.If that's needed in the meantime, calling
.display()on aPath/PathBufmakes themDisplay, fixing the issue.