367: Remove Canonical path and format Cloud path #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarrison
requested review from
SeanLeRoy,
aswallace,
lynwilhelm and
BrianWhitneyAI
pgarrison
changed the title
BrianWhitneyAI
approved these changes
Dec 20, 2024
| @@ -79,7 +81,11 @@ export default class FileDetail { | |||
| const pathWithoutDrive = path.replace("/allen/programs/allencell/data/proj0", ""); | |||
| // Should probably record this somewhere we can dynamically adjust to, or perhaps just in the file | |||
SeanLeRoy
approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
aswallace
approved these changes
Dec 20, 2024
|
@BrianWhitneyAI This PR is ready to merge once #370 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
With the new cloud-first FMS backend features, the
file_pathfrom FMS is a cloud path likestaging.files.allencell.org/c18/726/e93/ea3/804/468/34d/873/d6c/435/c6/aicsfiles-test-8c85cfec-bdc3-11ef-9089-0242ac110004.czi. This PR renders this as:File Path (Cloud) https://s3.us-west-2.amazonaws.com/staging.files.allencell.org/c18/726/e93/ea3/804/468/34d/873/d6c/435/c6/aicsfiles-test-8c85cfec-bdc3-11ef-9089-0242ac110004.czi.In addition, this PR removes the
File Path (Canonical). Along with #370, this completes the move from:To:
Closes #367
Changes
https://s3.us-west-2.amazonaws.com/to cloud pathsTesting
FileAnnotationListtests.