376: Downloads use labkey URL when file is available on Vast #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud-first FMS backend changes and existing updates for them (#370, #375) cause downloads to use the S3 URL. But for files available on the Vast, the download will be faster and use fewer resources if we download from the Vast via the labkey URL
http://aics.corp.alleninstitute.org/labkey/fmsfiles/image/allen/...
Closes #376
Testing
downloadPath
has the expected format.Notes
I believe we should merge this despite being unable to manually test it, because we know that the latest ETL pipeline changes will break the current
downloadPath
logic.