376: Downloads use labkey URL when file is available on Vast

packages/core/entity/FileDetail/index.ts

@@ -148,10 +148,10 @@ export default class FileDetail {
     }
 
     public get downloadPath(): string {
-        // For AICS files we don't have permission to the bucket nor do we expect to have the /allen
-        // drive mounted on the client machine. So we use the NGINX server to serve the file.
-        if (this.path.startsWith("/allen")) {
-            return `http://aics.corp.alleninstitute.org/labkey/fmsfiles/image${this.path}`;
+        // For AICS files that are available on the Vast, users can use the cloud path, but the
+        // download will be faster and not incur egress fees if we download via the local network.
+        if (this.localPath && this.localPath.startsWith("/allen")) {
+            return `http://aics.corp.alleninstitute.org/labkey/fmsfiles/image${this.localPath}`;
         }
 
         // Otherwise just return the path as is and hope for the best

packages/core/entity/FileDetail/test/FileDetail.test.ts

@@ -0,0 +1,29 @@
+import { expect } from "chai";
+
+import FileDetail from "..";
+
+describe("FileDetail", () => {
+    describe("file path representation", () => {
+        it("creates downloadPath from /allen path", () => {
+            // Arrange
+            const relativePath = "path/to/MyFile.txt";
+
+            // Act
+            const fileDetail = new FileDetail({
+                file_path: `production.files.allencell.org/${relativePath}`,
+                annotations: [
+                    {
+                        name: "Local File Path",
+                        values: [`/allen/programs/allencell/data/proj0/${relativePath}`],
+                    },
+                ],
+            });
+
+            // Assert
+            expect(fileDetail.downloadPath).to.equal(
+                // The downloadPath is HTTP, but will get redirected to HTTPS
+                `http://aics.corp.alleninstitute.org/labkey/fmsfiles/image/allen/programs/allencell/data/proj0/${relativePath}`
+            );
+        });
+    });
+});