-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch EcephysSession from SLIMS #38
Merged
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8f24fd3
Dome Module ephys logging
mekhlakapoor 00b8841
ExperimentRunStep and ExperimentRunStepContnet
mekhlakapoor 4bb11cb
methods to combine session-related data
mekhlakapoor 0281022
adds Rdrc models to fetch method
mekhlakapoor 524b564
fixes models, SlimsEcephysSession
mekhlakapoor 90f03ab
linters
mekhlakapoor 0b59884
fix conflicts
mekhlakapoor 3992994
Merge branch 'main' into feat-32-ecephys-rdrc
mekhlakapoor dd1f13d
post filter fix
mekhlakapoor 1e6b1e0
syncing remote and local
mekhlakapoor 56aa6f2
testing (wip)
mekhlakapoor dbb3354
unit tests
mekhlakapoor 2893927
simplifies experimentrunstep models
mekhlakapoor 1c505c2
adds example usage
mekhlakapoor d70b98b
linter
mekhlakapoor 4b7f5b2
requested changes
mekhlakapoor 2a59ada
updates docstrings
mekhlakapoor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super trivial, and I could be wrong but isn't it now preferred to use
list
overtyping.List
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, since the slims-api requires 3.10 and up, we can use the generic types