Update starter.cute.py: add fnv1a_hash for CuTeDSL#220
Closed
DiamondI wants to merge 1 commit intoAlphaGPU:mainfrom
Closed
Update starter.cute.py: add fnv1a_hash for CuTeDSL#220DiamondI wants to merge 1 commit intoAlphaGPU:mainfrom
DiamondI wants to merge 1 commit intoAlphaGPU:mainfrom
Conversation
Add fnv1a_hash for CuTeDSL
DiamondI
requested review from
ishaan-arya,
kunal-mansukhani and
shxjames
as code owners
kunal-mansukhani
approved these changes
Mar 21, 2026
Contributor
|
@claude please fix lint |
3 tasks
Contributor
|
Thanks for the contribution @DiamondI! There's a bug in this PR: I've opened a fix PR at #223 that adds the missing constant definitions inside the function body, matching the pattern used across CUDA, Triton, JAX, PyTorch, and Mojo starters. |
kunal-mansukhani
pushed a commit
that referenced
this pull request
Mar 21, 2026
* Update starter.cute.py: add fnv1a_hash for CuTeDSL Add fnv1a_hash for CuTeDSL * Fix missing FNV_PRIME and OFFSET_BASIS constants in CuTe starter The fnv1a_hash_u32_scalar helper referenced FNV_PRIME and OFFSET_BASIS without defining them, causing a NameError at runtime. Add the constant definitions inside the function body, matching the pattern used in all other framework starters (CUDA, Triton, JAX, PyTorch, Mojo). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Andrew <920076768@qq.com> Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fnv1a_hash for CuTeDSL