Fix missing FNV constants in CuTe rainbow table starter (PR #220)#223
Merged
kunal-mansukhani merged 2 commits intomainfrom Mar 21, 2026
Merged
Fix missing FNV constants in CuTe rainbow table starter (PR #220)#223kunal-mansukhani merged 2 commits intomainfrom
kunal-mansukhani merged 2 commits intomainfrom
Conversation
Add fnv1a_hash for CuTeDSL
The fnv1a_hash_u32_scalar helper referenced FNV_PRIME and OFFSET_BASIS without defining them, causing a NameError at runtime. Add the constant definitions inside the function body, matching the pattern used in all other framework starters (CUDA, Triton, JAX, PyTorch, Mojo). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
claude
bot
requested review from
ishaan-arya,
kunal-mansukhani and
shxjames
as code owners
kunal-mansukhani
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug introduced in fork PR #220 by @DiamondI.
fnv1a_hash_u32_scalarhelper function referencedFNV_PRIMEandOFFSET_BASISwithout defining them, which would cause aNameErrorat runtimeChanges
FNV_PRIME = 16777619andOFFSET_BASIS = 2166136261insidefnv1a_hash_u32_scalarinchallenges/easy/24_rainbow_table/starter/starter.cute.pyTest plan
challenge.pyand all other startersThis PR contains fixes for the fork PR #220 by @DiamondI
Original branch: patch-1
🤖 Generated with Claude Code