-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exprs refactor and reorg part 1 #1167
Conversation
Provides renames for both class names and filter graph names for most expression filters. |
@nicolemarsaglia FYI: Reorg with name changes, etc. Post this PR I will make more extensive additions. |
topo_sig["return_type"] = "topo"; | ||
topo_sig["filter_name"] = "topo"; | ||
topo_sig["return_type"] = "topology"; | ||
topo_sig["filter_name"] = "expr_mesh_topology"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this have the same filter name as topolgoy_sig below it (line 977)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, think of these as two aliases that map to the same filter.
However, I typo below -- we need to set params for:
topology_sig
instead of topo_sig
, or else topology_sig
isn't inited.
The original function name was only topo
, but I wanted us to be able to call the more explicit topology
as well.
The return type for both has to be topology
, b/c that is the new name I deemed moving forward for the expression language object that holds the topology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw your "?" comments on two of the args. Not sure if you wanted to change those now or wait
1389: field to scalar
1273: scalar to field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - thanks, I am still working on those two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the renaming is so so so so helpful
Getting this chunk in to open up the floor to more changes. |
No description provided.