Merged
Conversation
Clippy complained that: `assert_eq` of unit values detected. This will always succeed
Usage of this was removed in commit da4df87 PR Amanieu#189
Collaborator
Author
|
Also pulled in the removal of the |
Owner
|
This is technically a breaking change, but we're about to make a major version bump anyways... |
Owner
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 24, 2019
193: Misc clippy fixes r=Amanieu a=faern I went over the crates with Clippy. Some suggested changes are only stylistic, others more optimization oriented. The commit messages should hopefully explain well enough why each change was made. Otherwise see what clippy says on current master :) I left some warnings, since the suggested changes were not really objectively better, or possibly larger than what I wanted to do right now. Co-authored-by: Linus Färnstrand <faern@faern.net>
Collaborator
Author
|
My thought exactly. I'm bumping versions and drafting a changelog at the moment. Will submit soon. |
Contributor
bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
194: Add changelog entries and bump versions for 0.10.0 release r=Amanieu a=faern We must first let #193 be merged. Otherwise this changelog is not even correct. There were a lot of changes since last release. But the vast majority is reformatting and re-arranging to reduce the number of unsafe expressions. As well as adding safety invariant documentation and a few tests. These are cool improvements, but does not affect the public API. I can add something about it in the changelog if you think it's worth it. `lock_api` only has formatting changes and a few documentation improvements, so I don't think it needs a breaking version change. But might be worth releasing anyway to get the improved documentation out. The date in the changelog is simply tomorrow. Since I did not think we would have time to release today, and I did not want to just go with `2019-XX-YY` either. If we don't think we'll release tomorrow we can just fix that before merging this PR. Co-authored-by: Linus Färnstrand <faern@faern.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went over the crates with Clippy. Some suggested changes are only stylistic, others more optimization oriented. The commit messages should hopefully explain well enough why each change was made. Otherwise see what clippy says on current master :)
I left some warnings, since the suggested changes were not really objectively better, or possibly larger than what I wanted to do right now.