Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelfID: Make SELF ID messages optional #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muramura
Copy link
Contributor

  1. The SELF ID message is an optional specification.
  2. the number of characters in the text is also sent out when the number of characters is 0.
    I make the SELF ID message optional, in accordance with the F3411-22A specification.
    If the number of characters in the text is 0, there is no merit in sending the message.
    and one frame length is 25 bytes longer.
    I will only send out the message when the text is set.
    I will allow SELF ID messages to be set in the configuration parameter.

AFTER:
TEXT LEN > 0
Screenshot_20220922-110001360

TEXT LEN = 0
Screenshot_20220922-112207449

@tridge
Copy link
Contributor

tridge commented Jan 10, 2023

@muramura and @BluemarkInnovations Self-ID is marked with an asterix, which means:
image
the problem is, which jurisdictions? At the moment if not supplied we send a blank message, which seems fine to me. We could omit it, but it adds complexity

@friissoren
Copy link
Contributor

the problem is, which jurisdictions?

At least the rules and additional standardization documents in the US, EU and Japan all keep the Self ID message as optional. Whether any other jurisdiction will make it mandatory can only be speculated upon at this point.

@BluemarkInnovations
Copy link
Contributor

@tridge I think we need to add a region variable to the parameters. This allows to customize the arm_status_check function based on the region. For instance, if the region is set to EU, make the OPEN_DRONE_ID_OPERATOR_ID message mandatory. Otherwise fail the arm_status_check. I can work on such feature in a PR (this month).

In general, I favor not to send black messages.

@tridge
Copy link
Contributor

tridge commented Oct 16, 2023

this is handled by #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants