tinyalsa/test: clean up agmmixer API and fix issues #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorzappi
commented
Jan 25, 2026
victorzappi
commented
- Remove unused parameters from configure_mfc() and configure_pcm_converter() (tag, intf_name, rate)
- Remove unused local variables in set_agm_group_device_config()
- Fix memory leaks in set_agm_dp_audio_config_metadata()
- Fix usage() to display actual program name
- Rename ambiguous parameters (val -> stream_kv, dkv -> device_kv, val -> type, val_len -> tag_config_len/p_stream_len)
- Simplify get_tinyalsa_pcm_bit_width() control flow
- Add const qualifier to get_pcm_format() parameter
- Update all callers to match new signatures
- Remove unused parameters from configure_mfc() and configure_pcm_converter() (tag, intf_name, rate) - Remove unused local variables in set_agm_group_device_config() - Fix memory leaks in set_agm_dp_audio_config_metadata() - Fix usage() to display actual program name - Rename ambiguous parameters (val -> stream_kv, dkv -> device_kv, val -> type, val_len -> tag_config_len/p_stream_len) - Simplify get_tinyalsa_pcm_bit_width() control flow - Add const qualifier to get_pcm_format() parameter - Update all callers to match new signatures Signed-off-by: Victor Zappi <[email protected]>
Author
|
This is an external contribution. I don't have access to the Qualcomm Change Request system. Please let me know if there's a different process for community contributions. |
Author
|
I can't access the Coral Public CI logs (tests:qli failure) as they appear to be behind Qualcomm's internal login. Could you let me know what failed? |
|
@victorzappi can you please let me know if you have validated these changes? |
| STREAM_COMPRESS, dev_config[index].rate, dev_config[index].ch, | ||
| dev_config[index].bits, miid)) { | ||
| if (configure_mfc(mixer, device, STREAM_COMPRESS, dev_config[index].rate, | ||
| dev_config[index].ch,dev_config[index].bits, miid)) { |
There was a problem hiding this comment.
Please add space after comma : between dev_config[index].ch and dev_config[index].bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.