Skip to content

tinyalsa/test: clean up agmmixer API and fix issues #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victorzappi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tinyalsa/test: clean up agmmixer API and fix issues #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions plugins/tinyalsa/test/agmcap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ static void sigint_handler(int sig)
capturing = 0;
}

static void usage(void)
static void usage(char *progname)
{
printf(" Usage: %s file.wav [-help print usage] [-D card] [-d device]\n"
" [-c channels] [-r rate] [-b bits] [-p period_size]\n"
Expand All @@ -92,7 +92,7 @@ static void usage(void)
" [-is_24_LE] : [0-1] Only to be used if user wants to record 32 bps clip\n"
" [-usb_d usb device]\n"
" 0: If bps is 32, and format should be S32_LE\n"
" 1: If bps is 24, and format should be S24_LE\n");
" 1: If bps is 24, and format should be S24_LE\n", progname);
}

int main(int argc, char **argv)
Expand Down Expand Up @@ -120,7 +120,7 @@ int main(int argc, char **argv)
bool is_24_LE = false;

if (argc < 2) {
usage();
usage(argv[0]);
return 1;
}

Expand Down Expand Up @@ -194,7 +194,7 @@ int main(int argc, char **argv)
if (*argv)
usb_device = atoi(*argv);
}else if (strcmp(*argv, "-help") == 0) {
usage();
usage(argv[0]);
}
if (*argv)
argv++;
Expand Down Expand Up @@ -359,8 +359,8 @@ unsigned int capture_sample(FILE *file, unsigned int card, unsigned int device,
if (ret) {
printf("MFC not present for this graph\n");
} else {
if (configure_mfc(mixer, device, intf_name, TAG_STREAM_MFC,
STREAM_PCM, rate, channels, get_tinyalsa_pcm_bit_width(format), miid)) {
if (configure_mfc(mixer, device, STREAM_PCM, rate, channels,
get_tinyalsa_pcm_bit_width(format), miid)) {
printf("Failed to configure stream mfc\n");
goto err_close_mixer;
}
Expand Down
4 changes: 2 additions & 2 deletions plugins/tinyalsa/test/agmcompresscap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,8 @@ static void capture_samples(char *name, unsigned int card, unsigned int device,
if (ret) {
printf("MFC not present for this graph");
} else {
if (configure_mfc(mixer, device, intf_name, TAG_STREAM_MFC,
STREAM_COMPRESS, rate, channels, pcm_format_to_bits(format), miid)) {
if (configure_mfc(mixer, device, STREAM_COMPRESS, rate, channels,
pcm_format_to_bits(format), miid)) {
printf("Failed to configure pspd mfc\n");
goto mixer_exit;
}
Expand Down
5 changes: 2 additions & 3 deletions plugins/tinyalsa/test/agmcompressplay.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,9 +527,8 @@ void play_samples(char *name, unsigned int card, unsigned int device, unsigned i
if (ret) {
printf("MFC not present for this graph\n");
} else {
if (configure_mfc(mixer, device, intf_name[index], PER_STREAM_PER_DEVICE_MFC,
STREAM_COMPRESS, dev_config[index].rate, dev_config[index].ch,
dev_config[index].bits, miid)) {
if (configure_mfc(mixer, device, STREAM_COMPRESS, dev_config[index].rate,
dev_config[index].ch,dev_config[index].bits, miid)) {
Copy link

@Ritu-Sharma-3 Ritu-Sharma-3 Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add space after comma : between dev_config[index].ch and dev_config[index].bits

printf("Failed to configure pspd mfc\n");
goto MIXER_EXIT;
}
Expand Down
5 changes: 2 additions & 3 deletions plugins/tinyalsa/test/agmhostless.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,8 @@ void play_loopback(unsigned int card, unsigned int p_device, unsigned int c_devi
if (ret) {
printf("MFC not present for this graph\n");
} else {
if (configure_mfc(mixer, p_device, p_intf_name, PER_STREAM_PER_DEVICE_MFC,
STREAM_PCM, p_config->rate, p_config->ch,
p_config->bits, miid)) {
if (configure_mfc(mixer, p_device, STREAM_PCM, p_config->rate,
p_config->ch, p_config->bits, miid)) {
printf("Failed to configure pspd mfc\n");
goto err_disconnect;
}
Expand Down
Loading