Skip to content

fix(platform): add scoop paths for codex cli detection on windows#749

Open
danielfrey63 wants to merge 1 commit intoAutoMaker-Org:mainfrom
danielfrey63:fix/windows-scoop-detection
Open

fix(platform): add scoop paths for codex cli detection on windows#749
danielfrey63 wants to merge 1 commit intoAutoMaker-Org:mainfrom
danielfrey63:fix/windows-scoop-detection

Conversation

@danielfrey63
Copy link

@danielfrey63 danielfrey63 commented Feb 3, 2026

This PR adds support for detecting the Codex CLI when installed via Scoop (Windows). It includes paths for Scoop's Node.js current bin directory and global shims.

Summary by CodeRabbit

  • Bug Fixes
    • Improved detection of CLI tool installations on Windows systems using Scoop package manager, including standard and shimmed entry points.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @danielfrey63, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of detecting the Codex CLI on Windows systems. By integrating common installation paths used by the Scoop package manager, it ensures that users who install the CLI via Scoop will have their installations correctly recognized by the system.

Highlights

  • Windows Compatibility: Enhanced Codex CLI detection on Windows by incorporating paths for installations managed by Scoop.
  • Scoop Integration: Added specific path configurations for Scoop's Node.js global packages and global shims to ensure proper CLI discovery.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • libs/platform/src/system-paths.ts
    • Added new system paths to getCodexCliPaths to include various locations where the Codex CLI might be installed via Scoop on Windows, covering both Node.js global packages and global shims.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Extended Windows Codex CLI path detection to support Scoop-based Node.js installations. Added detection for codex entry points in Scoop package manager directories (scoop/apps/nodejs/current/bin and scoop/shims) alongside existing path resolution logic.

Changes

Cohort / File(s) Summary
Windows Codex Path Detection
libs/platform/src/system-paths.ts
Added Scoop package manager path entries for Codex CLI detection on Windows, including both nodejs app bin directory and shims directory routes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through Scoop so keen,
Finding paths where code convenes,
Windows whispers its secrets new,
Codex CLI shines through and through! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(platform): add scoop paths for codex cli detection on windows' clearly and concisely summarizes the main change: adding Scoop paths for Codex CLI detection on Windows. It is specific, directly related to the changeset, and provides meaningful information about the primary modification.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for detecting the Codex CLI on Windows when installed via Scoop. The changes add new search paths to getCodexCliPaths. My review identifies some redundant and likely incorrect paths that have been added. I've suggested their removal to improve correctness and maintainability.

Comment on lines +147 to +148
path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'codex.cmd'),
path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'codex'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These paths seem redundant and likely incorrect. When using a Scoop-installed Node.js, global npm packages are typically placed in the bin subdirectory of the Node.js installation, which is already covered by lines 145-146. The executables are not expected to be in the root of the current directory. I recommend removing these two lines to avoid unnecessary checks and potential false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant