fix(platform): add scoop paths for codex cli detection on windows#749
fix(platform): add scoop paths for codex cli detection on windows#749danielfrey63 wants to merge 1 commit intoAutoMaker-Org:mainfrom
Conversation
Summary of ChangesHello @danielfrey63, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of detecting the Codex CLI on Windows systems. By integrating common installation paths used by the Scoop package manager, it ensures that users who install the CLI via Scoop will have their installations correctly recognized by the system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughExtended Windows Codex CLI path detection to support Scoop-based Node.js installations. Added detection for codex entry points in Scoop package manager directories (scoop/apps/nodejs/current/bin and scoop/shims) alongside existing path resolution logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds support for detecting the Codex CLI on Windows when installed via Scoop. The changes add new search paths to getCodexCliPaths. My review identifies some redundant and likely incorrect paths that have been added. I've suggested their removal to improve correctness and maintainability.
| path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'codex.cmd'), | ||
| path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'codex'), |
There was a problem hiding this comment.
These paths seem redundant and likely incorrect. When using a Scoop-installed Node.js, global npm packages are typically placed in the bin subdirectory of the Node.js installation, which is already covered by lines 145-146. The executables are not expected to be in the root of the current directory. I recommend removing these two lines to avoid unnecessary checks and potential false positives.
This PR adds support for detecting the Codex CLI when installed via Scoop (Windows). It includes paths for Scoop's Node.js current bin directory and global shims.
Summary by CodeRabbit