Skip to content

fix(platform): add scoop paths for codex cli detection on windows #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielfrey63 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix(platform): add scoop paths for codex cli detection on windows #749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libs/platform/src/system-paths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,14 @@ export function getCodexCliPaths(): string[] {
// pnpm on Windows
path.join(localAppData, 'pnpm', 'codex.cmd'),
path.join(localAppData, 'pnpm', 'codex'),
// Scoop Node.js (global packages)
path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'bin', 'codex.cmd'),
path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'bin', 'codex'),
path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'codex.cmd'),
path.join(homeDir, 'scoop', 'apps', 'nodejs', 'current', 'codex'),
Comment on lines +147 to +148
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These paths seem redundant and likely incorrect. When using a Scoop-installed Node.js, global npm packages are typically placed in the bin subdirectory of the Node.js installation, which is already covered by lines 145-146. The executables are not expected to be in the root of the current directory. I recommend removing these two lines to avoid unnecessary checks and potential false positives.

// Scoop global shim
path.join(homeDir, 'scoop', 'shims', 'codex.cmd'),
path.join(homeDir, 'scoop', 'shims', 'codex'),
];
}

Expand Down