Skip to content

SQLite tests: use the UTF-16 STAT4 allocation range#932

Closed
brandonpayton wants to merge 1 commit into
gascity/kd-cfo/kd-c5i.8.1-fix-browser-sqllimits1-testrunner-outcome-list-accountinfrom
followup/sqlite-utf16-analyze9
Closed

SQLite tests: use the UTF-16 STAT4 allocation range#932
brandonpayton wants to merge 1 commit into
gascity/kd-cfo/kd-c5i.8.1-fix-browser-sqllimits1-testrunner-outcome-list-accountinfrom
followup/sqlite-utf16-analyze9

Conversation

@brandonpayton

Copy link
Copy Markdown
Member

Stacked on #783 so the same maintained Node and Chromium SQLite harness can exercise this test-only patch.

What #907 already landed

#907 landed the PHP batch and its platform fixes, including the mmap/munmap work. None of that runtime or ABI history is replayed here.

What remains here

SQLite's utf16 permutation stores the two STAT4 samples as roughly 2,000 bytes instead of the roughly 1,000 bytes used by the default encoding. This patch keeps analyze9-16.1's SCHEMA_USED assertion and selects the encoding-correct range when the active permutation is utf16.

What was deliberately removed

ABI and package artifacts

There is no ABI change. The declared SQLite library output is unchanged, so this does not bump the SQLite package revision. Rebuilding the separate testfixture and generated browser test image does change those local validation artifacts, but neither is a committed package output in this PR.

Validation run

Validation not run

  • the full SQLite permutation inventory;
  • full host Vitest and the non-slow browser suite;
  • package staging, because the declared library bytes do not change; and
  • performance benchmarks. This PR makes no performance claim.

A broader Chromium all analyze9.test diagnostic also ran the utf16 job successfully, but the overall command returned 1 because the separate pre-existing prepare.analyze9-9.4.1 job failed. That broader run is not claimed as passing validation for this PR.

Keep analyze9's memory-accounting assertion, but use the encoding-correct allocation delta for SQLite's utf16 permutation.
@github-actions

Copy link
Copy Markdown

Phase B-1 matrix build status — pr-932-staging

ABI v39. 5 built, 0 failed, 5 total.

Package Arch Status Sha
sqlite wasm32 built 5a13e73a
sqlite wasm64 built d7ce2dd3
php wasm32 built 9fd390fa
lamp wasm32 built ca2226cc
wordpress wasm32 built 0eb6e1e7

Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.

@brandonpayton

Copy link
Copy Markdown
Member Author

Closing this focused source PR because its unique UTF-16 STAT4 regression work is now carried by #934 at exact green head 260d75d5adc31b327f5591229dbfbb287d395fd6. #934 keeps it as a separate purpose commit and passed the full staging and browser gates. This is not a claim that this branch was merged verbatim.

@brandonpayton brandonpayton deleted the followup/sqlite-utf16-analyze9 branch July 14, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant