SQLite tests: use the UTF-16 STAT4 allocation range#932
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
Keep analyze9's memory-accounting assertion, but use the encoding-correct allocation delta for SQLite's utf16 permutation.
11e2073 to
52ba9a7
Compare
This was referenced Jul 13, 2026
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| sqlite | wasm32 | built | 5a13e73a |
| sqlite | wasm64 | built | d7ce2dd3 |
| php | wasm32 | built | 9fd390fa |
| lamp | wasm32 | built | ca2226cc |
| wordpress | wasm32 | built | 0eb6e1e7 |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
Member
Author
|
Closing this focused source PR because its unique UTF-16 STAT4 regression work is now carried by #934 at exact green head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #783 so the same maintained Node and Chromium SQLite harness can exercise this test-only patch.
What #907 already landed
#907 landed the PHP batch and its platform fixes, including the mmap/munmap work. None of that runtime or ABI history is replayed here.
What remains here
SQLite's
utf16permutation stores the two STAT4 samples as roughly 2,000 bytes instead of the roughly 1,000 bytes used by the default encoding. This patch keepsanalyze9-16.1'sSCHEMA_USEDassertion and selects the encoding-correct range when the active permutation isutf16.What was deliberately removed
no_mutex_try, pager-fault, or other SQLite workaround patches from Fix mmap accounting under partial munmap churn #769; andABI and package artifacts
There is no ABI change. The declared SQLite library output is unchanged, so this does not bump the SQLite package revision. Rebuilding the separate testfixture and generated browser test image does change those local validation artifacts, but neither is a committed package output in this PR.
Validation run
scripts/dev-shell.sh bash packages/registry/sqlite/build-testfixture.sh;all analyze9.test, which selectedconfig=utf16: 147 cases, 0 errors;utf16 analyze9.test: 147 cases, 0 errors; andgit diff --check.Validation not run
A broader Chromium
all analyze9.testdiagnostic also ran theutf16job successfully, but the overall command returned 1 because the separate pre-existingprepare.analyze9-9.4.1job failed. That broader run is not claimed as passing validation for this PR.