Skip to content

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 26, 2025

| 📘 Part of: # |
|:---:|

Fixes PCIOS-

This updates the deinit in Thread dictionary to be async but ensuring that the table is retained until the dealocation is complete.

To test

  • CI green should be enough

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.99 milestone Sep 26, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 26, 2025 11:39
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 26, 2025 11:39
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tun multiple times the tests and I never had a crash now. I left few comments below

@SergioEstevao
Copy link
Contributor Author

@danielebogo I accepted your suggestion and switched the print to a a log.

@danielebogo danielebogo requested a review from bjtitus September 26, 2025 17:59
@SergioEstevao SergioEstevao merged commit 26288a7 into trunk Sep 29, 2025
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the sergio/fix_tests branch September 29, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants