Skip to content

Ensure table is not dealocated before all work is done. #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

Ensure table is not dealocated before all work is done. #3528

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ff5109
Ensure table is not dealocated before all work is done.
SergioEstevao Sep 26, 2025
70e50eb
Update podcasts/ThreadSafeDictionary.swift
SergioEstevao Sep 26, 2025
ce49919
Import logger lib
SergioEstevao Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions podcasts/ThreadSafeDictionary.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import PocketCastsUtils

class ThreadSafeDictionary<Key: Hashable, Value> {

private let queue: DispatchQueue
Expand All @@ -9,9 +11,9 @@ class ThreadSafeDictionary<Key: Hashable, Value> {

deinit {
//ensure that all work is done before releasing the table
queue.sync(flags: .barrier) { [weak self] in
queue.async(flags: .barrier) { [table] in
//Last work item
self?.table.removeAll()
FileLog.shared.console("Dealocating table with \(table.count) elements")
}
}

Expand Down