Observability - Helm chart releases #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workflow trigger
* Chart version updates
* Chart dependencies
* Observability - new Otel and Grafana helm #61 * Dashboard update * GH worklow updates * Existing helm charts changes to take in observability
* Observability - new Otel and Grafana helm #61 * GH worklow simplify helm
* Observability - new Otel and Grafana helm #61 * GH worklow simplify helm * Typo in workflow * Helm chart minor updates
* Observability - new Otel and Grafana helm #61
* Observability - new Otel and Grafana helm #61 * Dashboard update * GH worklow updates * Chart version updates * Chart dependencies * Updated existing charts for observability * Updated release workflow * GH worklow simplify helm * Typo in workflow * Helm chart minor updates * Helm chart releaser workflow updates * Helm chart releaser CR
bindsi
approved these changes
Sep 21, 2023
bindsi
approved these changes
Sep 21, 2023
bindsi
previously approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Some serious amount of changes and improvements in this PR re observability ❤️ , but does require a significant intake of caffeine during the review process ☕.
Two overarching observations/requests here where possible: aim for smaller iterative changes/PR where possible and a diagram showing these new observability components would be extremely useful for showing a bigger picture (unless it's there and I missed?).
deployment/helm/edgeobservability/templates/grafana/deployment.yaml
Outdated
Show resolved
Hide resolved
suneetnangia
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR has more detailed documentation (part of a forthcoming PR): https://github.com/katriendg/distributed-az-edge-framework/blob/observability/docs/observability.md