Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping after healthz #3017

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Ping after healthz #3017

merged 4 commits into from
Jul 11, 2023

Conversation

s-amann
Copy link
Contributor

@s-amann s-amann commented Jul 11, 2023

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-3330

What this PR does / why we need it:

  1. Scrape metric for API server ping health if the healthz check returns a non 200. This will be used as a signal for Azure Resource Health check.

Test plan for issue:

INT deployment

Is there any documentation that needs to be updated for this PR?

Yes: https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/AzureRedHatOpenShift.wiki/484208/API-Server-Unreachable

@s-amann s-amann added ready-for-review next-release To be included in the next RP release rollout labels Jul 11, 2023
@cadenmarchese cadenmarchese merged commit 6cfcd6e into Azure:master Jul 11, 2023
18 checks passed
@cadenmarchese cadenmarchese mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennerv bennerv bennerv left review comments

@niontive niontive niontive approved these changes

@cadenmarchese cadenmarchese cadenmarchese approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@facchettos facchettos Awaiting requested review from facchettos

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@ellis-johnson ellis-johnson Awaiting requested review from ellis-johnson

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

Assignees
No one assigned
Labels
next-release To be included in the next RP release rollout ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-amann @bennerv @niontive @cadenmarchese