Fix NSG e2e error #3057
Merged
Fix NSG e2e error #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwnt
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
bennerv
requested changes
Jul 24, 2023
|
Please rebase pull request. |
bennerv
previously requested changes
Jul 26, 2023
s-amann
previously approved these changes
Aug 2, 2023
SudoBrendan
previously approved these changes
Aug 8, 2023
|
Please rebase pull request. |
update to go 1.18.10
nwnt
dismissed stale reviews from SudoBrendan, petrkotas, and s-amann
via
eb9df50
nwnt
force-pushed
the
fix-nsg-e2e-error
branch
from
a426616
to
eb9df50
Compare
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
nwnt
force-pushed
the
fix-nsg-e2e-error
branch
from
eb9df50
to
0ac69cb
Compare
nwnt
force-pushed
the
fix-nsg-e2e-error
branch
from
602938f
to
4643261
Compare
petrkotas
reviewed
Sep 12, 2023
| @@ -342,6 +342,15 @@ var _ = Describe("ARO Operator - Azure Subnet Reconciler", func() { | |||
| } | |||
|
|
|||
| BeforeEach(func(ctx context.Context) { | |||
| // TODO remove this when GA | |||
There was a problem hiding this comment.
@bennerv I think this is what you were asking for.
There was a problem hiding this comment.
it wasn't a remove when GA, but a "use the cluster document API field when GA"
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I cleared up with @bennerv that this is good to go. |
SrinivasAtmakuri
pushed a commit
to SrinivasAtmakuri/ARO-RP
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Amber Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original discussion thread:
https://redhat-external.slack.com/archives/C03F6AA3HDH/p1689891751922919
Which issue this PR addresses:
Fixes: the spring 239 release failure, ARO-3293
It also includes the changes reverted by #3058
What this PR does / why we need it:
Fix the subtle error found during the e2e test in Dev release. The error occurred when the new NSG validate function is called for the FP before the flag alternation in
checkPreconfiguredNSGcalled by validateSubnets. In e2e, the subnets will not have any NSG, but the new NSG validation accesses it. That's why it's giving a nil pointer reference error.Test plan for issue:
e2e and CI are now passed.
Is there any documentation that needs to be updated for this PR?
N/A