Reconcile Master & Current Release: Revert Preconfigured NSG Changes #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
requested review from
jewzaam,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
…zure#2969)" This reverts commit f87f198.
bennerv
force-pushed
the
release/sprint239_hotfix
branch
from
d5fa4ff
to
9c93de9
Compare
bennerv
changed the title
SudoBrendan
approved these changes
Jul 24, 2023
cadenmarchese
approved these changes
Jul 24, 2023
|
cc @nwnt - feel free to include this PR revert in your NSG PR once you have a fix up. |
|
This will be fixed in #3057 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes released to prod in release branch
release/sprint239_hotfixinto master to maintain some level of synchronization.Right now if you try deploying master + changes to any environment, it breaks if the AFEC feature flag is registered. We should maintain consistency between what's released / reverted and what current master looks like.
Changes should be cherry-picked from master into release branches, not the other way around.