Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: Add HTTP tracing option for MS Graph requests #3269

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

mbarnes
Copy link
Contributor

@mbarnes mbarnes commented Nov 8, 2023

What this PR does / why we need it:

I recently reconstructed how I originally enabled HTTP tracing for MS Graph requests when porting the RP from Azure Active Directory Graph last year. I'm offering this up as a permanent debugging feature, enabled by defining an environment variable named ARO_MSGRAPH_TRACE. It might come in handy again in the future.

Debug feature enabled by ARO_MSGRAPH_TRACE environment variable.
@mbarnes mbarnes removed the dependencies Pull requests that update a dependency file label Nov 8, 2023
@SudoBrendan
Copy link
Collaborator

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SudoBrendan
SudoBrendan previously approved these changes Nov 8, 2023
bennerv
bennerv previously approved these changes Nov 8, 2023
Copy link
Contributor

@s-amann s-amann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧔‍♂️

@bennerv bennerv merged commit d25e7f2 into Azure:master Nov 8, 2023
18 checks passed
@mbarnes mbarnes deleted the aro-msgraph-trace branch November 8, 2023 20:18
ventifus pushed a commit to ventifus/ARO-RP that referenced this pull request Feb 7, 2024
* graph: Add HTTP tracing option for MS Graph requests

Debug feature enabled by ARO_MSGRAPH_TRACE environment variable.

* graph: Temporarily disable gzip compression in requests

---------

Co-authored-by: Matthew Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants