Try and log the VM info + console log on failure #3287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
|
Please rebase pull request. |
hawkowl
force-pushed
the
hawkowl/e2e-failure-vm-status
branch
from
87f2e43
to
05bbff8
Compare
hawkowl
added
ready-for-review
skippy
hawkowl
force-pushed
the
hawkowl/e2e-failure-vm-status
branch
from
d7d4fca
to
5d3a3b8
Compare
hawkowl
force-pushed
the
hawkowl/e2e-failure-vm-status
branch
from
5d3a3b8
to
b285062
Compare
mociarain
approved these changes
Mar 7, 2024
| @@ -21,6 +21,11 @@ func FriendlyName(f interface{}) string { | |||
| return runtime.FuncForPC(reflect.ValueOf(f).Pointer()).Name() | |||
| } | |||
|
|
|||
| // FriendlyName returns a "friendly" stringified name of the given func. | |||
There was a problem hiding this comment.
Suggested change
| // FriendlyName returns a "friendly" stringified name of the given func. | |
| // ShortFriendlyName returns a short and "friendly" stringified name of the given func. |
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
|
See new PR #3629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ARO-5368
Dumps the VM info + console logs on failure so that we don't need to run the Geneva Action or have the control plane still around to get it.